Skip to content

fix more bugs in the user groups PR#1693

Open
pxsit wants to merge 2 commits intocms-dev:mainfrom
pxsit:fix-group
Open

fix more bugs in the user groups PR#1693
pxsit wants to merge 2 commits intocms-dev:mainfrom
pxsit:fix-group

Conversation

@pxsit
Copy link
Copy Markdown
Contributor

@pxsit pxsit commented May 4, 2026

Copilot AI review requested due to automatic review settings May 4, 2026 07:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes auto-registration failures introduced by the addition of mandatory user groups by ensuring newly created participations are assigned to the contest’s default (main) group.

Changes:

  • Assign group=self.contest.main_group when creating a Participation during contest registration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 53.89%. Comparing base (6a28840) to head (0ac0392).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cms/server/contest/handlers/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files         341      341           
  Lines       27977    27977           
=======================================
  Hits        15077    15077           
  Misses      12900    12900           
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 53.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@veluca93 veluca93 requested a review from prandla May 4, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants